Skip to content

Conversation

@lolski
Copy link
Member

@lolski lolski commented Nov 21, 2024

Release notes: usage and product changes

Declare user management messages and services, which lets the caller make user creation, update, deletion, and retrieval call through gRPC.

Implementation

Declare the associated gRPC services and Protobuf messages for user creation, update, deletion, and retrieval.

@typedb-bot
Copy link
Member

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.
@lolski lolski changed the title Authentication User authentication and management protocol Nov 21, 2024
@lolski lolski changed the title User authentication and management protocol User management protocol Nov 22, 2024
@lolski lolski marked this pull request as ready for review November 22, 2024 14:00
@lolski lolski requested a review from farost November 25, 2024 10:21
Copy link
Member

@farost farost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left some clarifications comments


// User API
rpc users_update (User.Update.Req) returns (User.Update.Res);
rpc users_delete (User.Delete.Req) returns (User.Delete.Res);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, adds symmetry with databases.

proto/user.proto Outdated
string password_new = 3;
string name = 1;
string password = 2;
User user = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we use the User for in the request? Do we find the existing user by this message, and are name and password the updated fields then?

@lolski lolski merged commit 7870373 into 3.0 Dec 6, 2024
1 check failed
@lolski lolski deleted the authentication branch December 6, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment