This repository was archived by the owner on Jan 18, 2020. It is now read-only.
Correctly find callInvite to cancel #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I'm a novice at iOS development, but in my attempt to copy this QuickStart implementation into hoxfon/react-native-twilio-programmable-voice#138 I needed to make this change to get the cancel to work correctly. I wanted to share this change with you, but I have not tested it in this repo myself. Please confirm and merge if it is an issue.
bobiechen-twilio suggested changes Dec 30, 2019
Contributor
bobiechen-twilio left a comment
bobiechen-twilio left a comment There was a problem hiding this comment.
Hi @lonnylot
Thanks for catching the bug and submitting the PR!
The logic of the changes look good, only a small naming suggestion so that the variable name matches Twilio design.
Contributor
| @lonnylot Thanks again! |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I'm a novice at iOS development, but in my attempt to copy this QuickStart implementation into hoxfon/react-native-twilio-programmable-voice#138 I needed to make this change to get the cancel to work correctly.
I wanted to share this change with you, but I have not tested it in this repo myself. Please confirm and merge if it is an issue.
Contributing to Twilio