Skip to content

Conversation

@manisha1997
Copy link
Contributor

@manisha1997 manisha1997 commented Jul 1, 2025

Fixes

This PR removes encoding in case of phone number format because all path params are anyway encoded https://github.com/twilio/twilio-java/blob/4f46e707d6931c50888c26b2dbd3c4452ea076e1/src/main/java/com/twilio/http/Request.java#L213

Preview PR: twilio/twilio-java#871

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified affected APIs by making calls

@manisha1997 manisha1997 merged commit 8d0667f into main Jul 2, 2025
14 of 16 checks passed
@manisha1997 manisha1997 deleted the number-encoding branch July 2, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants