Skip to content

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Apr 12, 2021

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

This PR updates the recording rules function so that it uses the twilio client that is returned by context.getTwilioClient(), instead of importing its own version with require.

It turns out, that the version of the twilio client returned by getTwilioClient() is determined by the twilio version specified in the package.json file that is used for deploying the functions (which can be found here). So it was never necessary to require('twilio') in order to get a version of the twilio client that had support for the recording rules API.

@timmydoza timmydoza requested a review from charliesantos April 12, 2021 21:04
@timmydoza timmydoza merged commit 195890c into master Apr 12, 2021
@timmydoza timmydoza deleted the use-default-twilio-client branch April 12, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants