Skip to content

Feature/start stop recording #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 6, 2021
Merged

Feature/start stop recording #60

merged 16 commits into from
Jan 6, 2021

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Jan 5, 2021 •
edited
Loading

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Ticket: https://issues.corp.twilio.com/browse/AHOYAPPS-958

The contents of this PR are identical to the contents of PR #55, with the exception of this commit, where I update the README to include information about the /recordingrules endpoint.
Tim Mendoza added 14 commits November 17, 2020 20:26
Create verify_passcode asset. Move token.js
165a2f1
Delete old token server
51332b4
Add recordingRules route
7856bb8
Move functions and assets from server/ to serverless/
10a23cb
Update helpers file to deploy new files
6f3d199
Add tests for verify_passcode and fix tests for token
c5de2dd
Add parameter validation and tests to recordingrules route
93efc81
Fix helpers tests
72fffc8
Change assets/verify_passcode.js to middleware/auth.js
3638ef5
Fix issue where middleware was not uploaded when an app-directory was…
81ec0e3 
… not provided Also, changed logic in getAppInfo so web app URL is only display when web assets exist
Fix lint error
c2bdc81
Add todo comment
ed99adc
Merge pull request #55 from twilio-labs/AHOYAPPS-946-start-stop-recor…
fe37558 
…ding Ahoyapps 946 start stop recording
Update readme to include recordingrules endpoint
28d0423
@timmydoza timmydoza requested a review from aaalaniz January 5, 2021 21:49
aaalaniz
aaalaniz suggested changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@aaalaniz aaalaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a minor version bump and add a changelog entry. Excellent work 👍🏼
@timmydoza timmydoza requested a review from aaalaniz January 6, 2021 00:01
@timmydoza timmydoza merged commit 2070cec into master Jan 6, 2021
@timmydoza timmydoza deleted the feature/start-stop-recording branch January 6, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@timmydoza @aaalaniz