Skip to content

Make token server editable in Functions #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 20, 2020
Merged

Make token server editable in Functions #49

merged 10 commits into from
Oct 20, 2020

Conversation

timmydoza
Copy link
Contributor

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.
aaalaniz
aaalaniz suggested changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@aaalaniz aaalaniz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

  1. Add a couple tests
  2. Bump to 0.6.0
  3. Add CL entry
  4. Add flag with default true

💯
@aaalaniz aaalaniz changed the title Log token server editor to console Make token server editable in Functions Oct 7, 2020
aaalaniz
aaalaniz previously approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@aaalaniz aaalaniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 👍🏼
@timmydoza timmydoza requested a review from aaalaniz October 20, 2020 19:53
@timmydoza timmydoza merged commit a6198bd into master Oct 20, 2020
@timmydoza timmydoza deleted the log-token-server-editor branch October 20, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@timmydoza @aaalaniz