Skip to content

Conversation

@timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Aug 5, 2022

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Description:

This PR adds error logging to the /token and /recording-rules endpoints. Any errors can now be seen in the logs of the Twilio Functions Editor, or your terminal when run locally. For example:

[server] Error creating room: [server] RestException [Error]: Authenticate [server] at success (/Users/tmendoza/projects/twilio-video-app-react/node_modules/twilio/lib/base/Version.js:135:15) [server] at Promise_then_fulfilled (/Users/tmendoza/projects/twilio-video-app-react/node_modules/twilio/node_modules/q/q.js:766:44) [server] at Promise_done_fulfilled (/Users/tmendoza/projects/twilio-video-app-react/node_modules/twilio/node_modules/q/q.js:835:31) [server] at Fulfilled_dispatch [as dispatch] (/Users/tmendoza/projects/twilio-video-app-react/node_modules/twilio/node_modules/q/q.js:1229:9) [server] at Pending_become_eachMessage_task (/Users/tmendoza/projects/twilio-video-app-react/node_modules/twilio/node_modules/q/q.js:1369:30) [server] at RawTask.call (/Users/tmendoza/projects/twilio-video-app-react/node_modules/asap/asap.js:40:19) [server] at flush (/Users/tmendoza/projects/twilio-video-app-react/node_modules/asap/raw.js:50:29) [server] at processTicksAndRejections (internal/process/task_queues.js:77:11) { [server] status: 401, [server] code: 20003, [server] moreInfo: 'https://www.twilio.com/docs/errors/20003', [server] details: undefined [server] } 

This PR also 1) removes package-lock.json, 2) updates some dependencies, and 3) prepares the package for the release of version 0.8.5.

@timmydoza timmydoza requested a review from olipyskoty August 5, 2022 16:28
Copy link
Contributor

@olipyskoty olipyskoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change

.gitignore Outdated
@@ -1,2 +1,3 @@
node_modules/
npm-debug.log*
package-lock.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line error

@timmydoza timmydoza requested a review from olipyskoty August 5, 2022 18:34
@timmydoza timmydoza changed the title Add error logging and prepare release of 0.8.5 Add error logging and prepare release of 0.8.4 Aug 5, 2022
@timmydoza timmydoza merged commit 5e625fd into master Aug 5, 2022
@timmydoza timmydoza deleted the add-error-logging branch August 5, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants