feat: texture layer rendering for JSCAD viewer #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for GitHub.
|
Abse2001 requested review from seveibar and removed request for ShiboSoftwareDev 
seveibar reviewed Dec 7, 2025
src/CadViewerJscad.tsx Outdated
| } catch (e) { | ||
| return 1.2 | ||
| } | ||
| }, [internalCircuitJson]) |
Contributor
There was a problem hiding this comment.
try to avoid top level pollution, move this to a method (the LoC on this file is very precious)
seveibar approved these changes Dec 7, 2025
| Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description: