Introduce Orthographic camera toggle #546
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar changed the title ![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines 11 to +14
| if (typeof window !== "undefined") { | ||
| window.TSCI_MAIN_CAMERA_ROTATION = new THREE.Euler(0, 0, 0) | ||
| window.TSCI_MAIN_CAMERA_QUATERNION = new THREE.Quaternion() |
Contributor
There was a problem hiding this comment.
Global window properties are unconditionally overwritten with new instances, while CadViewerContainer.tsx uses nullish coalescing assignment (??=). This creates an inconsistency where loading order matters.
If this file loads after CadViewerContainer.tsx, it will reset the global camera state, causing the RotationTracker's updates to be lost.
Fix:
window.TSCI_MAIN_CAMERA_ROTATION ??= new THREE.Euler(0, 0, 0) window.TSCI_MAIN_CAMERA_QUATERNION ??= new THREE.Quaternion() Suggested change
| if (typeof window !== "undefined") { | |
| window.TSCI_MAIN_CAMERA_ROTATION = new THREE.Euler(0, 0, 0) | |
| window.TSCI_MAIN_CAMERA_QUATERNION = new THREE.Quaternion() | |
| if (typeof window !== "undefined") { | |
| window.TSCI_MAIN_CAMERA_ROTATION ??= new THREE.Euler(0, 0, 0) | |
| window.TSCI_MAIN_CAMERA_QUATERNION ??= new THREE.Quaternion() | |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
Contributor Author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_b_6904dfb631b0832eb8f215c892938f78