Set STATUS mode for CMake message() function calls #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| Yes, that makes sense to me. Merging this will break backwards compatibility, but I doubt that anyone relies on this being printed to stderr and your use case is more common. Thanks for the contribution! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Not having a mode causes the message to print to stderr instead of stdout.
There are some setups where anything printed to stderr is considered an error for the purposes of determining if a subprocess worked or not. I recently encountered this problem where messages getting printed to stderr by CMake were causing commands to terminate (on CI builds) -- it seemed to be most problematic when using powershell to run a setuptools build (that compiles a native module using CMake).