-
Couldn't load subscription status.
- Fork 23
Deptry #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Warning Rate limit exceeded@tschm has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 23 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/pre-commit.yml (1)
29-30: Remove the redundant comment.Line 29–30 restates what is already clear from the container image specification on line 26. This comment can be safely removed.
Apply this diff:
container: image: pre-commit/mirrors:latest # Use pre-commit container for the entire job - - # use a dedicated pre-commit container
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/deptry.yml(1 hunks).github/workflows/pre-commit.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.8)
.github/workflows/deptry.yml
32-32: property "setup" is not defined in object type {}
(expression)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/pre-commit.yml (1)
48-49: Remove debug diagnostic output from the workflow.Lines 48–49 contain
ls -allcommands that appear to be diagnostic/debug artifacts left in during development. These should be removed from the production workflow as they provide no value to CI execution.Apply this diff to clean up the debug output:
- name: Run pre-commit hooks run: | - ls -all - ls -all .git pre-commit run --all-files # Run all hooks on all files
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/deptry.yml(2 hunks).github/workflows/pre-commit.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/deptry.yml (1)
29-34: ✅ Past critical issue has been properly resolved.The undefined
steps.setup.outputs.pyproject_existsreference has been fixed by replacing it with a local inline check forpyproject.toml. This implementation is self-contained and no longer depends on a removed setup step. The conditional logic is now correct and will skip deptry analysis gracefully when pyproject.toml is absent.
Summary by CodeRabbit