Skip to content

Conversation

@tschm
Copy link
Owner

@tschm tschm commented Oct 18, 2025

Summary by CodeRabbit

  • Chores
    • CI workflows updated to run in consistent container environments for checks.
    • Dependency-checking job now runs on pushes only and will skip gracefully when project metadata is absent.
    • Pre-commit checks consolidated into a single step with explicit installation of tooling.
    • Added a dedicated lint job to run style checks independently.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 18, 2025

Warning

Rate limit exceeded

@tschm has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 23 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6c0f27e and 6bc6588.

📒 Files selected for processing (3)
  • .github/workflows/pre-commit.yml (1 hunks)
  • Makefile (0 hunks)
  • taskfiles/quality.yml (1 hunks)

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive The title "Deptry" is a specific reference to a real component being modified in the changeset, referring to the deptry workflow updates. However, the title is extremely minimal and lacks descriptive context about what the change actually entails. A teammate scanning the git history would not understand whether the change involves refactoring, adding container support, updating logic, or something else entirely. Additionally, the changeset includes significant modifications to the pre-commit workflow, which is not reflected in the title at all. While the title is not completely misleading, it's too generic and vague to convey the nature and scope of the modifications. Consider revising the title to be more descriptive and specific about the actual changes. For example, something like "Refactor workflows to use uv container images" or "Update deptry and pre-commit workflows with container support" would better communicate the primary intent and scope of the changes to someone reviewing the commit history.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/pre-commit.yml (1)

29-30: Remove the redundant comment.

Line 29–30 restates what is already clear from the container image specification on line 26. This comment can be safely removed.

Apply this diff:

 container: image: pre-commit/mirrors:latest # Use pre-commit container for the entire job - - # use a dedicated pre-commit container
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 017f717 and 2d5ad0e.

📒 Files selected for processing (2)
  • .github/workflows/deptry.yml (1 hunks)
  • .github/workflows/pre-commit.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.8)
.github/workflows/deptry.yml

32-32: property "setup" is not defined in object type {}

(expression)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/pre-commit.yml (1)

48-49: Remove debug diagnostic output from the workflow.

Lines 48–49 contain ls -all commands that appear to be diagnostic/debug artifacts left in during development. These should be removed from the production workflow as they provide no value to CI execution.

Apply this diff to clean up the debug output:

 - name: Run pre-commit hooks run: | - ls -all - ls -all .git pre-commit run --all-files # Run all hooks on all files
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2d5ad0e and 6c0f27e.

📒 Files selected for processing (2)
  • .github/workflows/deptry.yml (2 hunks)
  • .github/workflows/pre-commit.yml (1 hunks)
🔇 Additional comments (1)
.github/workflows/deptry.yml (1)

29-34: ✅ Past critical issue has been properly resolved.

The undefined steps.setup.outputs.pyproject_exists reference has been fixed by replacing it with a local inline check for pyproject.toml. This implementation is self-contained and no longer depends on a removed setup step. The conditional logic is now correct and will skip deptry analysis gracefully when pyproject.toml is absent.

@tschm tschm merged commit 6386426 into main Oct 19, 2025
11 checks passed
@tschm tschm deleted the deptry branch October 19, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant