- Notifications
You must be signed in to change notification settings - Fork 203
Alex/eng 10 internal oss offering have bad documentation hard to setup #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Marfuen wants to merge 2 commits into main from alex/eng-10-internal-oss-offering-have-bad-documentation-hard-to-setup
Closed
Alex/eng 10 internal oss offering have bad documentation hard to setup #1709
Marfuen wants to merge 2 commits into main from alex/eng-10-internal-oss-offering-have-bad-documentation-hard-to-setup
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixed critical documentation issues: - Added all 11 NEXT_PUBLIC_* build args with explanations - Documented 4 separate .env file locations (packages/db, apps/app, apps/portal, root) - Added 39 missing environment variables including SECRET_KEY - Marked AWS S3 as REQUIRED with complete setup guide - Added Quick Setup Guide with external service instructions - Enhanced Resend and Trigger.dev sections with setup steps - Added build-time vs runtime variable distinction throughout - Added secret generation commands with openssl examples - Enhanced production tips section Addresses #1705
🔒 Comp AI - Security Review🔴 Risk Level: HIGHNo OSV CVEs found in scanned packages. Documentation (SELF_HOSTING.md) references plaintext .env secrets and credential names. 📦 Dependency Vulnerabilities✅ No known vulnerabilities detected in dependencies. 🛡️ Code Security AnalysisView 1 file(s) with issues🔴 SELF_HOSTING.md (HIGH Risk)
Recommendations:
💡 RecommendationsView 3 recommendation(s)
Powered by Comp AI - AI that handles compliance for you. Reviewed Oct 31, 2025 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist