chore: multiple os release setup #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Time Submission Status
|
Member
| Have you tested it on forked repository somewhere? @georgeciubotaru |
Member
| checking on my forked repo |
Member
| @georgeciubotaru I try it on my forked repo, but it fails More details: |
MicBun requested changes Jun 17, 2025
Member
MicBun left a comment
MicBun left a comment There was a problem hiding this comment.
I am unable to run the examples file now.
steps to reproduce
pip install --force-reinstall https://github.com/MicBun/sdk-py/releases/download/v0.3.4/trufnetwork_sdk_py-0.1.0-py3-none-any.whl cd examples python main.py logs
Traceback (most recent call last): File "/home/micbun/MicBun/sdk-py/examples/main.py", line 2, in <module> from trufnetwork_sdk_py.client import TNClient File "/home/micbun/MicBun/sdk-py/.venv/lib/python3.12/site-packages/trufnetwork_sdk_py/__init__.py", line 1, in <module> from .client import ( File "/home/micbun/MicBun/sdk-py/.venv/lib/python3.12/site-packages/trufnetwork_sdk_py/client.py", line 2, in <module> import trufnetwork_sdk_c_bindings.exports as truf_sdk File "/home/micbun/MicBun/sdk-py/.venv/lib/python3.12/site-packages/trufnetwork_sdk_c_bindings/exports.py", line 17, in <module> from . import _trufnetwork_sdk_c_bindings ImportError: cannot import name '_trufnetwork_sdk_c_bindings' from 'trufnetwork_sdk_c_bindings' (/home/micbun/MicBun/sdk-py/.venv/lib/python3.12/site-packages/trufnetwork_sdk_c_bindings/__init__.py) Member
| Is this also related? |
Member
| Now i got Have you try to install from created wheel? Is it working on Mac? @georgeciubotaru |
Contributor Author
| @MicBun Yes. followed the commands make gopy_build |
Member
| I still get this error when running examples (using pip install from whl) Building that tries to supports both os seems break things(?) Step I use
The fork https://github.com/MicBun/sdk-py/releases/tag/v0.3.3 |
Member
| Let's pause this in favor of higher priority tasks |
Member
| @williamrusdyputra could you help here if there are no higher priority tasks? I can't test the Mac part. |
Contributor
| @MicBun I got the error trying to install from released wheel, when I see George's commands, the reason he doesn't get this error is he used |
Contributor
| log: investigating |
Contributor
Causethe root cause is that during Actual vs Expectedthe wrong result caused this wheel distribution: notice that the platform specific string is not there, instead we got  FixModified setup.py class BinaryDistribution(Distribution): def has_ext_modules(self): return True setup( distclass=BinaryDistribution, zip_safe=False, # for packages that include compiled extensions |
Contributor
| @MicBun could you try again, using this PR changes to your forked repo note: you must add this change to your released version, so it uses the latest setup file from this PR |
williamrusdyputra force-pushed the feat/multiple-os-release branch from db5ecf7 to a3f7450 Compare <img width="1274" alt="Screenshot 2025-06-24 at 17 31 02" src="https://github.com/user-attachments/assets/92dd2459-7b3c-4a83-ad8b-bcda6ec4c3d0" /> repo: https://github.com/williamrusdyputra/sdk-py/releases/tag/v0.3.6 `pip install --force-reinstall https://github.com/williamrusdyputra/sdk-py/releases/download/v0.3.6/trufnetwork_sdk_py-0.3.3-cp312-cp312-macosx_14_0_universal2.whl`
Member
| Let me test one more times |
MicBun approved these changes Jun 24, 2025
MicBun changed the title 
MicBun pushed a commit that referenced this pull request Jun 26, 2025
## Description This PR resolves a shared library loading issue on Linux and introduces a robust testing framework to prevent future regressions. * **Fixes Linux `ImportError`**: The SDK's compiled Go library (`.so` file) is now built with an embedded `RPATH`. This makes the library self-contained and removes the need for users to manually configure `LD_LIBRARY_PATH`, simplifying installation. * **Adds Distribution Testing**: A new GitHub Actions workflow has been added to test the package distribution on Linux and macOS. This workflow builds the wheel in a clean Docker environment and runs a smoke test to ensure it installs and imports correctly, directly verifying the fix. * **Removes Documentation**: The `README.md` section detailing the `LD_LIBRARY_PATH` workaround has been removed as it is no longer necessary. ## Related Problem - related to #63 ## How Has This Been Tested? This change is validated by a new, automated CI workflow (`distribution-test.yml`). For every pull request, this workflow: 1. Builds the Python wheel from source inside a clean Docker container. 2. Installs the wheel into a lightweight, final Docker image. 3. Runs a test script (`get_account_test.py`) that confirms the SDK can be imported and used without any manual environment setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
resolves: #61