Updated README.md #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Returning a string a component creates the following TypeScript error in the parent component: > Type error: JSX element type 'string | Element' is not a constructor function for JSX elements. Type 'string' is not assignable to type 'Element | null'. TS2605 Better to return a proper element.
trojanowski requested changes Feb 22, 2019
Removed unnecessary $ Co-Authored-By: nareshbhatia <naresh.archfirst@gmail.com>
Remove unnecessary $ Co-Authored-By: nareshbhatia <naresh.archfirst@gmail.com>
trojanowski approved these changes Feb 22, 2019
Owner
| Thanks @nareshbhatia |
Contributor Author
| Welcome! Sorry about the oversight on |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Returning a string a component creates the following TypeScript error in the parent component:
Better to return a proper element.