Skip to content

Set query cancelled property only after cancelling #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2021
Merged

Set query cancelled property only after cancelling #86

merged 1 commit into from
Jun 29, 2021

Conversation

@joshthoward
Copy link
Member

@joshthoward joshthoward commented Apr 20, 2021

Moved the setter for the cancelled property following the check that the cancellation is successful.
@cla-bot cla-bot bot added the cla-signed label Apr 20, 2021
@joshthoward joshthoward requested a review from hashhar April 20, 2021 02:40
hashhar
hashhar approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. ❤️
@hashhar hashhar merged commit 63fc498 into trinodb:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed

2 participants

@joshthoward @hashhar