Update setup.py to add python 3.7, 3.8 and 3.9 to classifiers #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ebyhr reviewed Jan 17, 2021
Member
ebyhr left a comment
ebyhr left a comment There was a problem hiding this comment.
Please change commit message as "Add python 3.7, 3.8 and 3.9 to classifiers in setup.py" since 3.7 is missing in the current message.
yuokada force-pushed the classifiers-py37 branch from 4087215 to 993f5c8 Compare 
Contributor Author
| Sorry, fixed. |
yuokada changed the title ebyhr approved these changes Jan 18, 2021
Member
| @yuokada Merged, thanks! You don't need to separate a PR when the commit is related to each other tightly. Adding a commit is fine in such case. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Follow up #72 & #66
This PR should be merged after #72