Skip to content

Conversation

@andreif
Copy link

@andreif andreif commented Nov 24, 2017

Using inline comments in envlist config

[tox] envlist = one, # two, # three, four, # five

results in adding them as envs

$ tox -l one #two four #five

This PR fixes that

$ tox -l one four
@andreif
Copy link
Author

andreif commented Nov 24, 2017

It's a bit of mystery why only Python 3.3 failed on the first commit in PR tests https://travis-ci.org/tox-dev/tox/builds/306663767.
In my fork all except 2.6 failed as expected https://travis-ci.org/andreif/tox/builds/306663499

@RonnyPfannschmidt
Copy link

i restarted the build to check if this is a temporary hickup

@RonnyPfannschmidt
Copy link

the restarted env doesnt seem to expose the issue - @obestwalter its not clear whts causing the temporary hickup, but it indicates a hidden unreliability in the setup

@codecov
Copy link

codecov bot commented Nov 24, 2017

Codecov Report

Merging #680 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #680 +/- ## ======================================= Coverage 90.77% 90.77% ======================================= Files 11 11 Lines 2373 2373 Branches 402 403 +1 ======================================= Hits 2154 2154 Misses 144 144 Partials 75 75
Impacted Files Coverage Δ
tox/config.py 95.08% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc8934...fca2f67. Read the comment docs.

@gaborbernat gaborbernat merged commit 1b8ecc2 into tox-dev:master Dec 1, 2017
@andreif andreif deleted the feature/exclude-commented-envs branch December 1, 2017 09:30
@gaborbernat
Copy link
Member

@andreif can you add a PR containing the change description into the news section?

@andreif
Copy link
Author

andreif commented Dec 1, 2017

Sure, hopefully I'll do it correctly

@andreif
Copy link
Author

andreif commented Dec 1, 2017

@gaborbernat Hm, or maybe not. Do you mean changelog? Do I need to add 2.9.2 section? I feel that I am not having a clear picture of what I am doing so maybe I am not the best person to do it 😺

@obestwalter
Copy link
Member

the restarted env doesnt seem to expose the issue - @obestwalter its not clear whts causing the temporary hickup, but it indicates a hidden unreliability in the setup

Any idea what that could be? Which setup do you mean? travis? Wouldn't even know where to start looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants