If module is _io, use io instead #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Most of the io module is implemented in the private C extension module called _io. It would be friendly if Python set the module name to io to match the way it is documented but they don't.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Most of the io module is implemented in the private C extension module called _io. It would be friendly if Python set the module name to io to match the way it is documented but they don't.
I'm not sure how much it is desirable to add a bunch of module name redirects here. Also, perhaps it would be useful to have a configuration option that allows specifying more module redirects since reexporting classes is pretty common.