feat(c50): update challenge example #868
Conversation
| @tomalaforge as mentioned here, we should think about rename this challenge naming. If you want me to do this, just let me know. |
| constructor() { | ||
| /* | ||
| Explain for your junior team mate why this bug occurs ... | ||
| */ |
There was a problem hiding this comment.
This comment is not very useful to the challenge.
There was a problem hiding this comment.
To explain why this error occurs can be helpful to really understand it. But if you don't like it i can remove it.
| - Uncheck box 1 | ||
| - Check box 3 (Alert should be shown) | ||
| - Uncheck box 2 | ||
| - Uncheck box 3 |
There was a problem hiding this comment.
If we do it this way. the only way to solve the challenge is by having multiple effects. Otherwise even if we uncheck one checkbox, the alert will be shown.
There was a problem hiding this comment.
That would be okay for you? if so, we have to update our solutions
There was a problem hiding this comment.
It's just that the challenge was just about the issue on the effect. But this doesn't really matter. We can keep it this way. I just don't know how to do it simply with one effect
There was a problem hiding this comment.
Yeah you're right. I suggest to change line 40 to the following. So we can find different ways to solve this, maybe with one effect, i'll try this.
Try to implement this feature with a
computedsignal.
| Nice use case and if you want to change the title: what title will you use? |
For the title i prefer just "Effect bug", or "Bug in Effect" without the question mark. |
| I updated the project tree, so when this PR is done, I will move the app folder as well |
2 participants
Here is my feedback and additions for this new challenge.