This repository was archived by the owner on Jan 2, 2023. It is now read-only.
Added error handling #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
.gitignore Outdated
Contributor Author
There was a problem hiding this comment.
Adding files that you wish to be ignored?
Contributor
There was a problem hiding this comment.
that belongs in the global ignore file
Contributor Author
There was a problem hiding this comment.
That's the kind of feedback I was hoping for, instead of just a thumbs down. Bit more constructive - thanks.
Owner
| Can you please send this to the 0.2 branch? |
Contributor Author
| Yeah sure. There's still a bit that needs to come from this into this project, once the json-api has been updated. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Moves the JSON api error handling from the flarum/core project to this one. Includes tests.