This repository was archived by the owner on Jan 2, 2023. It is now read-only.
Hk kickstart test suite #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| See passing travis-ci here https://travis-ci.org/hanneskaeufler/json-api (phpcs seems incomp. with php 5.3 though) |
Owner
| Sorry for the delay. This is fantastic – really appreciate it! |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As is mentioned in #29 and #1 this package could use some automated tests. Maybe this start invites some other to contribute to the suite. this is obviously test after, so some unwanted behaviour might be baked into the tests. I also don´t know it this suites your style of testing, feel free to make comments!