Fix - Failing to get artwork from FLAC files #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| Thanks @paolovalerdi. Do you think we could grab the largest picture by byte size, as we do for non FLAC files? Just in case there are some thumbnails embedded, we don't really know which picture is the actual artwork, so we assume it's the largest one.. Also, any idea why this approach is required? Why are images available in the FLAC PictureList, but no in the Tag PictureMap? |
Contributor Author
| Sure I will work on that :) I'm not really sure, some point to some sort of base64 encoding This PR is actually an very quick and rough implementation of this answer |
Contributor Author
| Closed in favor of Android's native solution |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Very first implementation of this