added filter list with query parser #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| merge go-lang code |
dennigogo force-pushed the added-filter-list-with-query-parser branch 3 times, most recently from 75e23a1 to 4da503b Compare 
timsolov reviewed Oct 1, 2020
main.go Outdated
| for i := 0; i < len(q.Filters); i++ { | ||
| filter := q.Filters[i] | ||
| for key := range q.Filters { | ||
| where = `` |
main.go Outdated
| } else if filter.Or && OR { | ||
| prefix = " OR " | ||
| // if last element of next element not OR method | ||
| if i+1 == len(q.Filters[key]) || (i+1 < len(q.Filters[key]) && !q.Filters[key][key+1].Or) { |
There was a problem hiding this comment.
you have an error in:
q.Filters[key][key+1]
main.go Outdated
| where += fmt.Sprintf("%s%s%s", prefix, a, suffix) | ||
| } else { | ||
| continue | ||
| if where != `` { |
main.go Outdated
| } | ||
| | ||
| if len(whereList) == 0 { | ||
| return `` |
main.go Outdated
| } | ||
| | ||
| return where | ||
| return strings.Join(whereList, ` AND `) |
main.go Outdated
| | ||
| return " WHERE " + q.Where() | ||
| where := q.Where() | ||
| if where == `` { |
dennigogo force-pushed the added-filter-list-with-query-parser branch from 4da503b to d6af7f6 Compare dennigogo force-pushed the added-filter-list-with-query-parser branch 3 times, most recently from eefad9c to f66d5bb Compare dennigogo force-pushed the added-filter-list-with-query-parser branch 7 times, most recently from c762140 to 4ca7d68 Compare dennigogo force-pushed the added-filter-list-with-query-parser branch from 4ca7d68 to 586157a Compare 
timsolov pushed a commit that referenced this pull request Oct 13, 2020
merge timsolov/rest-query-parser::master to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.