Skip to content

Conversation

@knzo25
Copy link
Contributor

@knzo25 knzo25 commented Sep 30, 2024

Description

Making a dummy PR do evaluate and comment about the changes required to perform radar calibration in the garage

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@knzo25 knzo25 marked this pull request as draft September 30, 2024 05:48
@knzo25
Copy link
Contributor Author

knzo25 commented Sep 30, 2024

@vividf
This time I can run the code normally, but it is impossible to perform a correct analysis with all the false positives from you and other people appearing in front of the lidar and being detected as markers

Please provide a commit in which this does not happen. This should be possible by setting an appropriate max cluster z.
If not, a max cluster height (difference between min and max z). If even that is not enough, please try some approaches on your end

@vividf
Copy link
Contributor

vividf commented Oct 1, 2024

I changed the cluster max size from 2000 to 500 and it became more stable.
Also, for rear_center bags, please use bag 2 and bag 3 which has more stable lidar (because I didn't open rviz)
https://github.com/vividf/CalibrationTools/tree/t4_garage_xx1_experiment

@vividf
Copy link
Contributor

vividf commented Oct 3, 2024

@knzo25 branch is updated for some changes.

* chore: tune parameter setting for smooth calibration Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix default rviz for text markers Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix default rviz for text markers Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove unused header Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: change function name to evaluateCombinations Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: change function name to get2DRotationDelta Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: change variable name Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix waiting to extract the background model Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix grammar error Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix function name and clean code Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove unnessary logging Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix int to size_t Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix estimateZeroRollTransformation logging Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: add std::size_t Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: NULL to nullptr Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: declare point type only once Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove class member and declare new structure Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix description of radar_optimization_frame Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove if condition Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: fix function name setDelta Signed-off-by: vividf <yihsiang.fang@tier4.jp> --------- Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants