Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

Conversation

@ricardopereira
Copy link
Contributor

No description provided.

@mattheworiordan
Copy link

Looks good @ricardopereira :)

Worth having a few high level tests perhaps from Obj-C to prove interoperability firstly, but also to ensure there are no regressions? I expect this can be done easily with some very high level tests just checking that the interface works as expected.

@tidwall
Copy link
Owner

tidwall commented Dec 15, 2015

@ricardopereira Very cool! I did a cursory review and I don't see anything alarming. l'll poke around a bit and test it in some of my projects.

tidwall added a commit that referenced this pull request Dec 15, 2015
@tidwall tidwall merged commit 0a82f8b into tidwall:dev Dec 15, 2015
@tidwall
Copy link
Owner

tidwall commented Dec 15, 2015

It passes all the Autobahn tests and runs fine in swift as far as I can tell. I haven't tested it with objective-c yet. At this point we should probably have a simple unit test specifically for objective-c that binds all the delegate methods. Ideally connecting to an echo service similar to the example code in the Readme.

@ricardopereira
Copy link
Contributor Author

@ricardopereira ricardopereira deleted the dev-objc branch January 5, 2016 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants