Skip to content

Conversation

@jobisoft
Copy link
Contributor

Found this while fixing some of the broken links, which are due to ESMIfication.

@jobisoft jobisoft requested a review from hellsworth September 17, 2024 14:23
@jobisoft jobisoft self-assigned this Sep 17, 2024
@hellsworth
Copy link
Contributor

hellsworth commented Sep 17, 2024

I know that *sys.mjs files are what many *.jsm files have been converted to so that seems like a modern change that makes sense.

I am not well versed in javascript though. Did you test out this snippet somehow? I copy pasted it into the error console.. does this look right?
image

@jobisoft
Copy link
Contributor Author

I know that *sys.mjs files are what many *.jsm files have been converted to so that seems like a modern change that makes sense.

I am not well versed in javascript though. Did you test out this snippet somehow? I copy pasted it into the error console.. does this look right? image

That is exactly how I verified that code. The result looks correct.

@hellsworth
Copy link
Contributor

hmm. I tested this in the most recent TB nightly. What version did you test / expect some different result?

@jobisoft
Copy link
Contributor Author

jobisoft commented Sep 17, 2024

I tested in TB115 and TB128. Output:

IRC	prpl-irc XMPP	prpl-jabber Matrix	prpl-matrix Odnoklassniki	prpl-odnoklassniki 

Neither my new code, nor the old code works in TB102, because the file imServices.jsm does not exist, it was renamed from TB91 to TB102 from imServices.jsm to IMServices.jsm. The old code does work in TB91. Output:

IRC	prpl-irc XMPP	prpl-jabber Odnoklassniki	prpl-odnoklassniki 

So the new code in TB115/128 has similar output to the original code in TB91 (matrix was added after TB91). This looks all good to me.

@hellsworth
Copy link
Contributor

Thanks again!

@hellsworth hellsworth merged commit 3bc6c44 into master Nov 6, 2024
@jobisoft jobisoft deleted the fix-chat-example branch September 30, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants