Skip to content

refac: Use RestController and RestControllerAdvice for pure REST APIs #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

refac: Use RestController and RestControllerAdvice for pure REST APIs #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/api/src/main/kotlin/com/github/thorlauridsen/controller/CustomerController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import com.github.thorlauridsen.dto.CustomerInputDto
import com.github.thorlauridsen.dto.toDto
import com.github.thorlauridsen.service.CustomerService
import jakarta.validation.Valid
import org.springframework.http.ResponseEntity
import org.springframework.stereotype.Controller
import java.net.URI
import java.util.UUID
import org.springframework.http.ResponseEntity
import org.springframework.web.bind.annotation.RestController

/**
* This REST controller consists of endpoints for:
Expand All @@ -21,7 +21,7 @@ import java.util.UUID
*
* @param customerService [CustomerService] service layer.
*/
@Controller
@RestController
class CustomerController(private val customerService: CustomerService) : ICustomerController {

/**
Expand Down
4 changes: 2 additions & 2 deletions apps/api/src/main/kotlin/com/github/thorlauridsen/exception/ControllerAdvisor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@ import org.springframework.http.HttpStatus
import org.springframework.http.HttpStatusCode
import org.springframework.http.ResponseEntity
import org.springframework.web.bind.MethodArgumentNotValidException
import org.springframework.web.bind.annotation.ControllerAdvice
import org.springframework.web.bind.annotation.ExceptionHandler
import org.springframework.web.bind.annotation.RestControllerAdvice
import org.springframework.web.context.request.WebRequest
import org.springframework.web.servlet.mvc.method.annotation.ResponseEntityExceptionHandler

/**
* Controller advisor for handling exceptions.
* This ensures that whenever an exception is thrown, a proper error response is returned to the client.
*/
@ControllerAdvice
@RestControllerAdvice
class ControllerAdvisor : ResponseEntityExceptionHandler() {

private val logger = LoggerFactory.getLogger(this::class.java)
Expand Down