- Notifications
You must be signed in to change notification settings - Fork 538
chore: optimize onekey logo #2369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: optimize onekey logo #2369
Conversation
@ByteZhang1024 is attempting to deploy a commit to the thirdweb Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe SVG icon in the codebase was updated by changing its width and height attributes from fixed pixel values to percentages, making the icon responsive to its container. No changes were made to the SVG's content or to any exported or public entities. Changes
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/injected/src/icons/onekey.ts (2)
2-2
: Preserve aspect ratio
To maintain the original proportions when scaling, consider addingpreserveAspectRatio="xMidYMid meet"
.- <svg width="100%" height="100%" viewBox="0 0 450 450" fill="none" xmlns="http://www.w3.org/2000/svg"> + <svg width="100%" height="100%" viewBox="0 0 450 450" preserveAspectRatio="xMidYMid meet" fill="none" xmlns="http://www.w3.org/2000/svg">
2-2
: Accessibility: consider ARIA attributes
If this SVG is decorative, addaria-hidden="true"
. If it conveys meaningful content, includerole="img"
and a<title>
element for screen readers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/injected/src/icons/onekey.ts
(1 hunks)
🔇 Additional comments (2)
packages/injected/src/icons/onekey.ts (2)
2-2
: Switch to percentage-based dimensions
Changingwidth
andheight
from fixed pixels to100%
allows the SVG to scale with its container, improving responsiveness.
2-2
: Ensure parent container dimensions
Withwidth="100%" height="100%"
, the SVG’s rendered size depends entirely on its container. Verify that all usage sites define explicit container dimensions or the icon may collapse to zero size.
* Setting up GitHub CI for packages * Pin github ci version * update node version for all packages (#2367) * update node version for all packages * update * chore: optimize onekey logo (#2369) * fix: revert @web3-onboard/para in docs to 1.0.0 (#2372) * fix: revert @web3-onboard/para in docs to 1.0.0 * add missing thirdweb icon --------- Co-authored-by: Jake Loo <2171134+jakeloo@users.noreply.github.com> Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> Co-authored-by: ByteZhang <ByteZhang@protonmail.com>
* fix: keystone dep breaks yarn 4 installation If you try to use web3-onboard with yarn v4 (although I think the problem will be there with yarn v2 and v3) it fails with: YN0001: │ Error: @keystonehq/eth-keyring@^0.14.00.3 isn't supported by any available resolver First install is ok, but if you run the install again you’ll get the above. 0.14.00.3 is apparently not a valid range and the only way to get this fixed is to fix the dependency. Yarn v1 resolves 0.14.00.3 to 0.14.4 and that is the version I’ve set here. * feature: thirdweb branding * fix: powered by thirdweb link * release: bump versions * chore: bump metamask to 0.32.0 * patch cbwsdk * update versions * update keystone package * lock * update node version in CI * bump node version for keystone ci job * Bump @trezor/connect-web to version 9.5.0 * bump node version for CI * github actions too * update brand * icon update * update version * update version * update wagmi for para * post rebase * feat: add link to thirdweb logo * Setting up GitHub CI for packages * Pin github ci version * update node version for all packages (#2367) * update node version for all packages * update * Update CI (#2368) * Setting up GitHub CI for packages * Pin github ci version * update node version for all packages (#2367) * update node version for all packages * update --------- Co-authored-by: Jake Loo <2171134+jakeloo@users.noreply.github.com> * chore: optimize onekey logo (#2369) * fix: revert @web3-onboard/para in docs to 1.0.0 (#2372) * fix: revert @web3-onboard/para in docs to 1.0.0 * add missing thirdweb icon * Chore: update git pages action (#2375) * fix: revert @web3-onboard/para in docs to 1.0.0 * chore: update git pages * remove auto trigger * rename blocknative URLs to thirdweb --------- Co-authored-by: Daniel Dimitrov <daniel@compojoom.com> Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> Co-authored-by: gregfromstl <gregfromstl@gmail.com> Co-authored-by: Tamas <soostamas.hu@gmail.com> Co-authored-by: Jake Feldman <95890768+cb-jake@users.noreply.github.com> Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> Co-authored-by: Tomas Martykan <t.martykan@gmail.com> Co-authored-by: Taylor Bosch <43397354+tbosch82@users.noreply.github.com> Co-authored-by: Jake Loo <2171134+jakeloo@users.noreply.github.com> Co-authored-by: ByteZhang <ByteZhang@protonmail.com>
* Setting up GitHub CI for packages * Pin github ci version * update node version for all packages (#2367) * update node version for all packages * update * chore: optimize onekey logo (#2369) * fix: revert @web3-onboard/para in docs to 1.0.0 (#2372) * fix: revert @web3-onboard/para in docs to 1.0.0 * add missing thirdweb icon * Chore: update git pages action (#2375) * fix: revert @web3-onboard/para in docs to 1.0.0 * chore: update git pages * remove auto trigger * rename blocknative URLs to thirdweb * chore: git action to push to main + docs (#2378) * chore: git action to push to main + docs * lint * chore: fix footer size/colors (#2379) * chore: fix footer size/colors * remove push to prod action * chore: remove blocknative links from header (#2381) * chore: upgrade WalletConnect dependencies (#2385) * chore: upgrade WalletConnect dependencies * chore: upgrade version * bump version --------- Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> --------- Co-authored-by: Jake Loo <2171134+jakeloo@users.noreply.github.com> Co-authored-by: ByteZhang <ByteZhang@protonmail.com> Co-authored-by: Phillip Ho <arcoraven@gmail.com> Co-authored-by: Derek <alexanderderekrein@gmail.com>
Description
Optimize OneKey logo style
Summary by CodeRabbit