Skip to content

Conversation

ByteZhang1024
Copy link
Contributor

@ByteZhang1024 ByteZhang1024 commented Jun 4, 2025

Description

Optimize OneKey logo style

Summary by CodeRabbit

  • Style
    • Updated icon scaling to be responsive, allowing the icon to adjust its size based on its container instead of using a fixed size.
Copy link

vercel bot commented Jun 4, 2025

@ByteZhang1024 is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

coderabbitai bot commented Jun 4, 2025

Walkthrough

The SVG icon in the codebase was updated by changing its width and height attributes from fixed pixel values to percentages, making the icon responsive to its container. No changes were made to the SVG's content or to any exported or public entities.

Changes

File Change Summary
packages/injected/src/icons/onekey.ts Changed SVG width and height from fixed pixels to 100%.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
packages/injected/src/icons/onekey.ts (2)

2-2: Preserve aspect ratio
To maintain the original proportions when scaling, consider adding preserveAspectRatio="xMidYMid meet".

- <svg width="100%" height="100%" viewBox="0 0 450 450" fill="none" xmlns="http://www.w3.org/2000/svg"> + <svg width="100%" height="100%" viewBox="0 0 450 450" preserveAspectRatio="xMidYMid meet" fill="none" xmlns="http://www.w3.org/2000/svg">

2-2: Accessibility: consider ARIA attributes
If this SVG is decorative, add aria-hidden="true". If it conveys meaningful content, include role="img" and a <title> element for screen readers.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 57b00e5 and c2e2366.

📒 Files selected for processing (1)
  • packages/injected/src/icons/onekey.ts (1 hunks)
🔇 Additional comments (2)
packages/injected/src/icons/onekey.ts (2)

2-2: Switch to percentage-based dimensions
Changing width and height from fixed pixels to 100% allows the SVG to scale with its container, improving responsiveness.


2-2: Ensure parent container dimensions
With width="100%" height="100%", the SVG’s rendered size depends entirely on its container. Verify that all usage sites define explicit container dimensions or the icon may collapse to zero size.

@ByteZhang1024
Copy link
Contributor Author

@joaquim-verges joaquim-verges merged commit e66cf8f into thirdweb-dev:develop Jul 4, 2025
3 of 4 checks passed
arcoraven added a commit that referenced this pull request Jul 22, 2025
* Setting up GitHub CI for packages * Pin github ci version * update node version for all packages (#2367) * update node version for all packages * update * chore: optimize onekey logo (#2369) * fix: revert @web3-onboard/para in docs to 1.0.0 (#2372) * fix: revert @web3-onboard/para in docs to 1.0.0 * add missing thirdweb icon --------- Co-authored-by: Jake Loo <2171134+jakeloo@users.noreply.github.com> Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> Co-authored-by: ByteZhang <ByteZhang@protonmail.com>
arcoraven added a commit that referenced this pull request Jul 23, 2025
* fix: keystone dep breaks yarn 4 installation If you try to use web3-onboard with yarn v4 (although I think the problem will be there with yarn v2 and v3) it fails with: YN0001: │ Error: @keystonehq/eth-keyring@^0.14.00.3 isn't supported by any available resolver First install is ok, but if you run the install again you’ll get the above. 0.14.00.3 is apparently not a valid range and the only way to get this fixed is to fix the dependency. Yarn v1 resolves 0.14.00.3 to 0.14.4 and that is the version I’ve set here. * feature: thirdweb branding * fix: powered by thirdweb link * release: bump versions * chore: bump metamask to 0.32.0 * patch cbwsdk * update versions * update keystone package * lock * update node version in CI * bump node version for keystone ci job * Bump @trezor/connect-web to version 9.5.0 * bump node version for CI * github actions too * update brand * icon update * update version * update version * update wagmi for para * post rebase * feat: add link to thirdweb logo * Setting up GitHub CI for packages * Pin github ci version * update node version for all packages (#2367) * update node version for all packages * update * Update CI (#2368) * Setting up GitHub CI for packages * Pin github ci version * update node version for all packages (#2367) * update node version for all packages * update --------- Co-authored-by: Jake Loo <2171134+jakeloo@users.noreply.github.com> * chore: optimize onekey logo (#2369) * fix: revert @web3-onboard/para in docs to 1.0.0 (#2372) * fix: revert @web3-onboard/para in docs to 1.0.0 * add missing thirdweb icon * Chore: update git pages action (#2375) * fix: revert @web3-onboard/para in docs to 1.0.0 * chore: update git pages * remove auto trigger * rename blocknative URLs to thirdweb --------- Co-authored-by: Daniel Dimitrov <daniel@compojoom.com> Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> Co-authored-by: gregfromstl <gregfromstl@gmail.com> Co-authored-by: Tamas <soostamas.hu@gmail.com> Co-authored-by: Jake Feldman <95890768+cb-jake@users.noreply.github.com> Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> Co-authored-by: Tomas Martykan <t.martykan@gmail.com> Co-authored-by: Taylor Bosch <43397354+tbosch82@users.noreply.github.com> Co-authored-by: Jake Loo <2171134+jakeloo@users.noreply.github.com> Co-authored-by: ByteZhang <ByteZhang@protonmail.com>
joaquim-verges added a commit that referenced this pull request Oct 9, 2025
* Setting up GitHub CI for packages * Pin github ci version * update node version for all packages (#2367) * update node version for all packages * update * chore: optimize onekey logo (#2369) * fix: revert @web3-onboard/para in docs to 1.0.0 (#2372) * fix: revert @web3-onboard/para in docs to 1.0.0 * add missing thirdweb icon * Chore: update git pages action (#2375) * fix: revert @web3-onboard/para in docs to 1.0.0 * chore: update git pages * remove auto trigger * rename blocknative URLs to thirdweb * chore: git action to push to main + docs (#2378) * chore: git action to push to main + docs * lint * chore: fix footer size/colors (#2379) * chore: fix footer size/colors * remove push to prod action * chore: remove blocknative links from header (#2381) * chore: upgrade WalletConnect dependencies (#2385) * chore: upgrade WalletConnect dependencies * chore: upgrade version * bump version --------- Co-authored-by: Joaquim Verges <joaquim.verges@gmail.com> --------- Co-authored-by: Jake Loo <2171134+jakeloo@users.noreply.github.com> Co-authored-by: ByteZhang <ByteZhang@protonmail.com> Co-authored-by: Phillip Ho <arcoraven@gmail.com> Co-authored-by: Derek <alexanderderekrein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants