Skip to content

Conversation

sigmoidr
Copy link
Contributor

@sigmoidr sigmoidr commented Dec 4, 2024

helpers.ts:

- return !!provider.providers?.some(provider => checkProviderIdentity({ provider, device })); + return Array.isArray(provider.providers) && !!provider.providers.some(provider => checkProviderIdentity({ provider, device }));

wallets.ts:

- checkProviderIdentity: ({ provider }) => !!provider && !!provider['ethereum'][ProviderIdentityFlag.Bitget], + checkProviderIdentity: ({ provider }) => !!provider && !!provider['ethereum'] && !!provider['ethereum'][ProviderIdentityFlag.Bitget]
Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This null check looks good and passes testing

@Adamj1232 Adamj1232 merged commit 9db4d8e into thirdweb-dev:develop Dec 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants