Skip to content

Conversation

omridan159
Copy link
Contributor

@omridan159 omridan159 commented Jun 20, 2024

Description

Update the metamask-sdk package to version '0.26.1'

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect
Copy link

socket-security bot commented Jun 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/code-frame@7.24.7 environment 0 24.1 kB nicolo-ribaudo
npm/@babel/compat-data@7.24.7 None 0 65.6 kB nicolo-ribaudo
npm/@babel/core@7.24.7 environment, filesystem, unsafe +1 840 kB nicolo-ribaudo
npm/@babel/generator@7.24.7 None +3 797 kB nicolo-ribaudo
npm/@babel/helper-compilation-targets@7.24.7 None 0 52.2 kB nicolo-ribaudo
npm/@babel/helper-environment-visitor@7.24.7 None 0 6.72 kB nicolo-ribaudo
npm/@babel/helper-function-name@7.24.7 None 0 21.7 kB nicolo-ribaudo
npm/@babel/helper-hoist-variables@7.24.7 None 0 6.99 kB nicolo-ribaudo
npm/@babel/helper-module-imports@7.24.7 None 0 63.7 kB nicolo-ribaudo
npm/@babel/helper-module-transforms@7.24.7 None 0 158 kB nicolo-ribaudo
npm/@babel/helper-plugin-utils@7.24.7 None 0 127 kB nicolo-ribaudo
npm/@babel/helper-simple-access@7.24.7 None 0 14.1 kB nicolo-ribaudo
npm/@babel/helper-split-export-declaration@7.24.7 None 0 10.8 kB nicolo-ribaudo
npm/@babel/helper-string-parser@7.24.7 None 0 31.8 kB nicolo-ribaudo
npm/@babel/helper-validator-identifier@7.24.7 None 0 49.3 kB nicolo-ribaudo
npm/@babel/helper-validator-option@7.24.7 None 0 11.8 kB nicolo-ribaudo
npm/@babel/helpers@7.24.7 None 0 859 kB nicolo-ribaudo
npm/@babel/highlight@7.24.7 environment +1 47.2 kB nicolo-ribaudo
npm/@babel/parser@7.24.7 None 0 1.89 MB nicolo-ribaudo
npm/@babel/runtime@7.21.0 None 0 258 kB nicolo-ribaudo
npm/@babel/template@7.24.7 None 0 69 kB nicolo-ribaudo
npm/@babel/traverse@7.24.7 None 0 634 kB nicolo-ribaudo
npm/@babel/types@7.24.7 environment 0 2.41 MB nicolo-ribaudo
npm/@ensdomains/address-encoder@0.1.9 None 0 2.21 MB makoto_inoue
npm/@ensdomains/ens@0.4.5 None 0 3.96 MB makoto_inoue
npm/@ensdomains/ensjs@2.1.0 None +2 15.8 MB nickjohnson
npm/@eslint-community/eslint-utils@4.3.0 None 0 375 kB eslint-community-bot
npm/@ethereumjs/common@2.5.0 None +3 6.45 MB holgerd77
npm/@ethereumjs/tx@3.3.2 None +1 4.02 MB holgerd77
npm/@ethersproject/abi@5.7.0 None 0 498 kB ricmoo
npm/@ethersproject/abstract-provider@5.7.0 None 0 61 kB ricmoo
npm/@ethersproject/abstract-signer@5.7.0 None 0 82.2 kB ricmoo
npm/@ethersproject/address@5.7.0 None 0 33.1 kB ricmoo
npm/@ethersproject/base64@5.7.0 None 0 11.3 kB ricmoo
npm/@ethersproject/basex@5.7.0 None 0 30.1 kB ricmoo
npm/@ethersproject/bignumber@5.7.0 None 0 143 kB ricmoo
npm/@ethersproject/bytes@5.7.0 None 0 80.9 kB ricmoo
npm/@ethersproject/constants@5.7.0 None 0 18.7 kB ricmoo
npm/@ethersproject/contracts@5.7.0 None 0 250 kB ricmoo
npm/@ethersproject/hash@5.7.0 None 0 257 kB ricmoo
npm/@ethersproject/hdnode@5.7.0 None 0 80.7 kB ricmoo
npm/@ethersproject/json-wallets@5.7.0 None 0 125 kB ricmoo
npm/@ethersproject/keccak256@5.7.0 None 0 6.09 kB ricmoo
npm/@ethersproject/logger@5.7.0 None 0 69.5 kB ricmoo
npm/@ethersproject/networks@5.7.1 None 0 47.5 kB ricmoo
npm/@ethersproject/pbkdf2@5.7.0 None 0 17.4 kB ricmoo
npm/@ethersproject/properties@5.7.0 None 0 31 kB ricmoo
npm/@ethersproject/providers@5.7.2 network 0 1.2 MB ricmoo
npm/@ethersproject/random@5.7.0 None 0 17.3 kB ricmoo
npm/@ethersproject/rlp@5.7.0 None 0 29.6 kB ricmoo
npm/@ethersproject/sha2@5.7.0 None 0 21.7 kB ricmoo
npm/@ethersproject/signing-key@5.7.0 None 0 244 kB ricmoo
npm/@ethersproject/solidity@5.7.0 None 0 23.2 kB ricmoo
npm/@ethersproject/strings@5.7.0 None 0 119 kB ricmoo
npm/@ethersproject/transactions@5.7.0 None 0 89.6 kB ricmoo
npm/@ethersproject/units@5.7.0 None 0 20.2 kB ricmoo
npm/@ethersproject/wallet@5.7.0 None 0 55.2 kB ricmoo
npm/@ethersproject/web@5.7.1 network 0 128 kB ricmoo
npm/@ethersproject/wordlists@5.7.0 None 0 390 kB ricmoo
npm/@jridgewell/gen-mapping@0.1.1 None 0 52.4 kB jridgewell
npm/@jridgewell/set-array@1.2.1 None 0 17.9 kB jridgewell
npm/@jridgewell/sourcemap-codec@1.4.14 None 0 40 kB jridgewell
npm/@jridgewell/trace-mapping@0.3.17 None +1 219 kB jridgewell
npm/@ledgerhq/devices@4.78.0 None +1 95.8 kB gre
npm/@ledgerhq/errors@4.78.0 None 0 90.7 kB gre
npm/@ledgerhq/hw-transport@4.74.2 None 0 68.2 kB gre
npm/@playwright/test@1.31.2 environment, eval, filesystem, network, shell, unsafe +1 6.31 MB aslushnikov
npm/@sindresorhus/is@0.7.0 None 0 88.6 kB sindresorhus
npm/@synthetixio/synpress@3.5.1 environment, filesystem Transitive: eval, network, unsafe +112 44.1 MB drptbl
npm/@szmarczak/http-timer@4.0.6 None 0 10.8 kB szmarczak
npm/@truffle/abi-utils@0.3.9 None +2 3.87 MB eggplantzzz
npm/@truffle/blockchain-utils@0.1.7 None 0 13.6 kB eggplantzzz
npm/@truffle/codec@0.14.16 None +5 12.9 MB eggplantzzz
npm/@truffle/contract-schema@3.4.13 None 0 277 kB eggplantzzz
npm/@truffle/contract@4.6.18 Transitive: network +17 55.7 MB eggplantzzz
npm/@types/cacheable-request@6.0.3 None +4 3.66 MB types
npm/@types/express-serve-static-core@4.17.33 None +3 3.69 MB types
npm/@types/express@4.17.17 None +4 3.66 MB types
npm/@types/istanbul-lib-coverage@2.0.4 None 0 5.76 kB types
npm/@types/serve-static@1.15.1 None +2 3.64 MB types
npm/@types/tapable@1.0.8 None 0 17.9 kB types
npm/@typescript-eslint/utils@5.56.0 Transitive: environment, filesystem +8 2.08 MB jameshenry
npm/abi-decoder@2.3.0 None 0 264 kB denisgranha
npm/accepts@1.3.8 None 0 16.8 kB dougwilson
npm/ansi-styles@3.2.1 None +1 36.3 kB sindresorhus
npm/anymatch@3.1.3 None 0 9.65 kB phated
npm/arg@5.0.2 None 0 13.7 kB leerobinson
npm/assert-plus@1.0.0 environment 0 11.4 kB pfmooney
npm/babel-core@6.26.3 environment, filesystem, unsafe +10 212 kB loganfsmyth

🚮 Removed packages: npm/@types/node@17.0.45, npm/nanoid@4.0.2

View full report↗︎

Copy link

socket-security bot commented Jun 20, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

},
"dependencies": {
"@metamask/sdk": "^0.20.5",
"@metamask/sdk": "^0.26.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package version on line 3 needs an alpha version bump and also needs to be reflected and tested in packages/demo/package.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-06-21 at 10 25 25
Copy link
Contributor Author

@omridan159 omridan159 Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating the MetaMask SDK package to version 2.1.3-alpha.1, I encounter an issue when I go to the demo test dapp and try to run yarn after also updating MetaMask there to "@web3-onboard/metamask": "^2.1.3-alpha.1".

What am I missing in my setup? @Adamj1232

@omridan159 omridan159 requested a review from Adamj1232 June 21, 2024 08:07
@omridan159 omridan159 changed the title chore: update the 'metamask-sdk' package to version '0.26.0' chore: update the 'metamask-sdk' package to version '0.26.1' Jun 21, 2024
Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Adamj1232 Adamj1232 merged commit 1b98647 into thirdweb-dev:develop Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants