Skip to content

Conversation

Adamj1232
Copy link
Contributor

Description

This PR adds an init parameter consecutiveEmptyAccountThreshold with type number to HW wallets that use Account Select (trezor, keepkey & keystone).
This parameter defaults to 5
This can be changed by the dev to allow more or less consecutive empty addresses between addresses with balance when looping through the hardware wallet accounts.

Screenshot 2023-05-12 at 1 26 31 PM

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation
@vercel
Copy link

vercel bot commented May 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 2:35pm
@socket-security
Copy link

socket-security bot commented May 12, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@web3-onboard/dcent@2.2.3 None +1 cmeisl
@web3-onboard/keepkey@2.3.3 None +1 cmeisl
@web3-onboard/keystone@2.3.3 None +1 cmeisl
@web3-onboard/trezor@2.3.3 None +1 cmeisl
Copy link
Contributor

@leightkt leightkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a trezor wallet- so I can't test locally, but the code looks good!

Copy link
Contributor

@lnbc1QWFyb24 lnbc1QWFyb24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question around the validation type.

Co-authored-by: Aaron <abarnard@protonmail.com>
@Adamj1232 Adamj1232 merged commit 303822d into develop May 16, 2023
@Adamj1232 Adamj1232 deleted the feat/hw_zeroBalanceThresh branch May 16, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants