- Notifications
You must be signed in to change notification settings - Fork 537
Feat: Private/custom rpc flow #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- use theme vars - remove rpc specific css vars - adjust spacing - remove unused css classes
leightkt reviewed May 12, 2023
Button looks good and is working as expected! |
leightkt previously approved these changes May 12, 2023
leightkt reviewed May 12, 2023
lnbc1QWFyb24 approved these changes May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a small typo in there I think.
Co-authored-by: Aaron <abarnard@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality to to Account Center expanded to allow end users to update their RPC on mainnet.
If the user's primary wallet is on mainnet and
disableProtectedRpc
is not set to true within the w3o init the button will display to update their RPC.The RPC endpoint is configurable per chain obj (although this functionality is only enabled on mainnet) and will default to the BN protect RPC
There is also a localstorage set and get that adds a key after/if the user updates their RPC to the defined RPC so the btn will no longer be shown. We could update this to show a green shield in the future if protection is enabled.
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errors