Skip to content

update dev dependency install instructions #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2023
Merged

update dev dependency install instructions #1646

merged 1 commit into from
Apr 18, 2023

Conversation

leightkt
Copy link
Contributor

@leightkt leightkt commented Apr 17, 2023 •
edited
Loading

Description

Updating dev dependency install instructions for sveltekit and vite per exchange: #1645

Screenshot 2023-04-17 at 4 57 26 PM

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • [NA] Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • [NA] Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • [NA] Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)
@leightkt leightkt self-assigned this Apr 17, 2023
@vercel
Copy link

vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3-onboard-docs ✅ Ready (Inspect) Visit Preview Apr 17, 2023 11:01pm
Adamj1232
Adamj1232 approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this @leightkt !
@leightkt leightkt merged commit 6190df2 into develop Apr 18, 2023
@leightkt leightkt deleted the update-notes-for-vite-dependencies branch April 18, 2023 16:26
This was referenced Apr 20, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@leightkt @Adamj1232