Skip to content

Why Don't I See My Wallet Link #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 3, 2023
Merged

Why Don't I See My Wallet Link #1617

merged 13 commits into from
Apr 3, 2023

Conversation

leightkt
Copy link
Contributor

@leightkt leightkt commented Mar 30, 2023 •
edited
Loading

Description

Add Info Box at the end of wallets with "why don't I see my wallet" link
Add customizable 'wheresMyWalletLink' link to connect

FIGMA

Screenshot 2023-03-30 at 9 51 02 AM

Screenshot 2023-03-30 at 9 51 14 AM

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

Screenshot 2023-03-30 at 9 57 56 AM
@leightkt leightkt self-assigned this Mar 30, 2023
@vercel
Copy link

vercel bot commented Mar 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ❌ Failed (Inspect) Apr 3, 2023 4:39pm
@leightkt leightkt marked this pull request as draft March 30, 2023 16:04
@leightkt leightkt marked this pull request as ready for review March 30, 2023 16:13
Adamj1232
Adamj1232 reviewed Mar 30, 2023
View reviewed changes
Adamj1232
Adamj1232 reviewed Mar 30, 2023
View reviewed changes
Adamj1232
Adamj1232 suggested changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need version bumps within the React and Vue packages to publish new packages with the core version bumps represented.
@leightkt leightkt requested a review from Adamj1232 March 30, 2023 17:23
Adamj1232
Adamj1232 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM!!
@leightkt leightkt requested a review from gesquinca March 30, 2023 21:14
gesquinca
gesquinca approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@gesquinca gesquinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just made a few padding and margin tweaks.
Adamj1232
Adamj1232 reviewed Apr 3, 2023
View reviewed changes
packages/core/src/views/shared/Warning.svelte
<style>
.container {
padding: var(--onboard-spacing-5, var(--spacing-5));
gap: 1rem;
Copy link
Contributor

@Adamj1232 Adamj1232 Apr 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier?
@leightkt leightkt merged commit 3f96812 into develop Apr 3, 2023
@leightkt leightkt deleted the why-dont-i-see-my-wallet branch April 3, 2023 16:41
Adamj1232
Adamj1232 reviewed Apr 3, 2023
View reviewed changes
packages/core/src/views/shared/Warning.svelte
p {
margin: 0;
width: fit-content;
flex: 0 0 auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier?
This was referenced Apr 3, 2023
Merged
Merged
Merged
Adamj1232 added a commit that referenced this pull request Apr 4, 2023
@Adamj1232 @leightkt
Merge pull request #1625 from blocknative/release/2.21.1
a1fd489 
* Yarn docs * update favicon on docs site (#1611) * Update Notify section on the docs site and within readme (#1612) * Update notify docs on docs site and within readme * Update notify api docs * Add screenshots * Update signup link * Remove export from types in docs * Update Docs Favicon to Url (#1618) * Fix broken link in docs (#1616) * Add Kat to GH issue and notion card generation + Fix doc prop name for connect property (#1593) * Yarn the docs * Fix doc prop name for connect property * Add new notion Flag * Add Kat to gh issue notion cards * Update Broken Links on Docs Pages (#1619) * Update WalletConnect `eth_RequestAccounts` flow along with update WC deps and add new optional params (#1622) * Update WC packages * Add logs for testing * Refactor eth_requestAccounts flow * Why Don't I See My Wallet Link (#1617) * Add peer dep required to run package outside of walletconnect eco (#1623) * Update versions for release * Bump versions --------- Co-authored-by: Kat Leight <33187102+leightkt@users.noreply.github.com>
@dankcellar
Copy link

But how do I hide it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@leightkt @dankcellar @gesquinca @Adamj1232