Skip to content

Conversation

leightkt
Copy link
Contributor

@leightkt leightkt commented Mar 9, 2023

Description

Updates PR template and Contribution Guide

Screenshot 2023-03-08 at 4 40 30 PM

Screenshot 2023-03-08 at 4 40 56 PM

Screenshot 2023-03-08 at 4 41 08 PM

Screenshot 2023-03-08 at 4 41 24 PM

Screenshot 2023-03-08 at 4 41 33 PM

Checklist

  • The version field in package.json of the package you have made changes in is incremented following semantic versioning and using alpha release tagging
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn file-check, yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

Tests with demo app (SDK)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect
@leightkt leightkt self-assigned this Mar 9, 2023
@vercel
Copy link

vercel bot commented Mar 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web3-onboard-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 6:24PM (UTC)
Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes but it looks a lot better! Thanks for doing this @leightkt!!

@leightkt
Copy link
Contributor Author

leightkt commented Mar 9, 2023

Screenshot 2023-03-09 at 11 13 57 AM

Screenshot 2023-03-09 at 11 14 20 AM

Screenshot 2023-03-09 at 11 14 56 AM

Copy link
Contributor

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@lnbc1QWFyb24 lnbc1QWFyb24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@leightkt leightkt merged commit b521e22 into develop Mar 13, 2023
@leightkt leightkt deleted the include-docs-in-PR-checklist branch March 13, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants