Skip to content

Conversation

Adamj1232
Copy link
Contributor

@Adamj1232 Adamj1232 commented Mar 8, 2023

Description

SvelteKit+Vite - Fix config issue with sveltekit and vite config -
Update docs around this config and add links to examples

Screen Shot 2023-03-08 at 4 11 21 PM

Adds context for to docs #1568

Checklist

  • The version field in package.json of the package you have made changes in is incremented following semantic versioning and using alpha release tagging
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn file-check, yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks
@Adamj1232 Adamj1232 requested a review from taylorjdawson March 8, 2023 23:11
@vercel
Copy link

vercel bot commented Mar 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
web3-onboard-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 10, 2023 at 5:10PM (UTC)
@Adamj1232 Adamj1232 requested a review from leightkt March 8, 2023 23:12
@Adamj1232 Adamj1232 merged commit dc50c34 into develop Mar 10, 2023
@Adamj1232 Adamj1232 deleted the fix/sveltekit_example branch March 10, 2023 17:23
Adamj1232 added a commit that referenced this pull request Mar 14, 2023
* yarn latest packages * Temporarily remove infinity wallet * Fix/sitemap (#1565) * update root path * Update the sitemap generation * Create new package for TallyHo name change to Taho (#1542) * Rename TallyHo wallet name to Taho * Remove commented out code * Remove unneeded file * Refine deploy script * Revert docs changes * Update more docs * Add Taho docs and fix connect wallet button issue * [core, react, vue]: Fix - Remove wallet from localStorage when disconnect is called with the primary wallet label (#1566) * Add removal of localstorage wallet string on disconnect * Add check to confirm the disconnected wallet is also the primary/current wallet * Revert demo change * Fix sitemap (#1573) * SvelteKit+Vite - Fix config issue with sveltekit and vite config - Add docs (#1569) * Fix config issue with sveltekit and vite config * Update package.json * Add examples to docs * Fix funk formatting * Add more notes around sveltekit+vite config and pnpm usage * [walletconnect-v2.3.1-alpha.1]: Update - walletConnect params to include `requiredChains` and updated WC deps (#1574) * Update wc package to the latest and parameterize required chains * Update WC module to allow req chains as parameter * Update docs * Update docs * Update package versions * Fix wc package versioning (#1581) --------- Co-authored-by: Aaron <abarnard@protonmail.com> Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants