Skip to content

Conversation

@lukeholder
Copy link
Contributor

@lukeholder lukeholder commented Aug 18, 2016

Added support for the new Netbanx (Optimal Payments / Paysafe) Hosted Payments gateway API support.

Supports:

  • Purchase (redirect)
  • Authorize (redirect)
  • Capture
  • Refund

All new Netbanx customers are not allowed to use the old API anymore.

API Docs: https://developer.optimalpayments.com/en/documentation/hosted-payment-api/overview/

Tests for capture() and refund() (success and failure casses) still needed.

The start of the new hosted gateway API support. Tests for capture and refund success and failure needed.
@lukeholder
Copy link
Contributor Author

@greydnls once I get tests for refund and capture, as well as code formatting passing on travisCI, would you be the person to merge?

@delatbabel
Copy link
Contributor

The official maintainer for this gateway is @borNfreee although any of the omnipay team can do the merge.

@lukeholder
Copy link
Contributor Author

thanks @delatbabel will ping once ready.

@lukeholder
Copy link
Contributor Author

This is my first time building a 'full' omnipay gateway, feedback welcome @borNfreee

@lukeholder lukeholder changed the title Hosted Gateway API Support New Hosted Payments API Support Aug 18, 2016
@lukeholder lukeholder changed the title New Hosted Payments API Support New Netbanx Hosted Payments API Support Aug 18, 2016
@@ -0,0 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you should not commit any .idea/* files to this repository. Remove them please

@maks-rafalko
Copy link

@lukeholder Hello, I'm not a maintainer of this NetBanx omnipay repository, I'm just a person who created it initialy without commit/merge access.

In general, you PR looks good but please ping the real maintainer

@delatbabel
Copy link
Contributor

Ping @barryvdh -- the omnipay repository has @borNfreee listed as the maintainer but I guess that should switch to one of the Omnipay team. Do you want to pick it up? NetBanx is EU so I guess closer to your sphere of influence than mine.

@borNfreee thanks for your work + code analysis.

@barryvdh
Copy link
Member

@delatbabel To be honest, I never heard of this gateway and have no way of testing.

I'd rather make @borNfreee or @lukeholder a maintainer, as they both use it and clearly do have knowledge about this gateway. What do you think?

@lukeholder
Copy link
Contributor Author

@barryvdh happy to put my hand up

@delatbabel
Copy link
Contributor

@barryvdh happy to put my hand up

Clearly showing insufficient reluctance.

@lukeholder lukeholder closed this Aug 25, 2016
@lukeholder lukeholder deleted the feature/hosted-gateway branch August 25, 2016 23:48
@lukeholder
Copy link
Contributor Author

switched to new branch name so I can composer install my fork, so new pull request:

#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants