fix(pagination theme file): added enabled attribute for pagination ba… #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tulup-conner requested changes Jul 14, 2023
Collaborator
tulup-conner left a comment
tulup-conner left a comment There was a problem hiding this comment.
This looks good, but please edit your post by following the Pull Request template, which you can see here: https://github.com/themesberg/flowbite-react/blob/main/.github/PULL_REQUEST_TEMPLATE.md
Collaborator
| Convert this back to ready for review once you've done that and I'll merge this |
Contributor Author
Hey @tulup-conner , I changed the PR comments. This is the best I can do please let me know if it needs more improvement by sharing a sample PR. |
…se theme hover class was getting applied even when button is disabled. so, added enabled: attribute to each hover class of pagination base theme. Now it will only show hover if button is enabled. fix themesberg#849
rluders force-pushed the fix/disabled-hover-on-pagination branch from 531cf57 to cec7c0a Compare 
rluders approved these changes Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Tailwind css class attribute change. Hover class was getting applied even when button was disabled. so, added enabled: attribute to each hover class of pagination base theme. Now it will only show hover effect if button is enabled.
Fixes #849
No breaking changes.