Fix : CheckBox Dark Mode Bug #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #1160 +/- ## ========================================== - Coverage 99.54% 97.38% -2.17% ========================================== Files 163 213 +50 Lines 6621 9049 +2428 Branches 401 528 +127 ========================================== + Hits 6591 8812 +2221 - Misses 30 237 +207 ☔ View full report in Codecov by Sentry. |
tulup-conner approved these changes Dec 1, 2023
Collaborator
tulup-conner left a comment
tulup-conner left a comment There was a problem hiding this comment.
Thanks so much!
BTW, it looks like this is actually an issue for Radios in dark mode as well. If you have time to take that on it would also be much appreciated. It looks like that one's a bit different - the ring is white and also cyan.
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summarize the changes made and the motivation behind them.
Reference related issues using
#followed by the issue number.<Checkbox>doesn't have outline in dark mode #1159If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.