feat(component): toggleSwitch add sizing prop (sm|md|lg) #1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@ ## main #1009 +/- ## ========================================== - Coverage 99.54% 93.45% -6.10% ========================================== Files 163 182 +19 Lines 6621 7911 +1290 Branches 401 442 +41 ========================================== + Hits 6591 7393 +802 - Misses 30 518 +488
☔ View full report in Codecov by Sentry. |
rluders approved these changes Sep 29, 2023
Collaborator
rluders left a comment
rluders left a comment There was a problem hiding this comment.
Nice one, @MateoWartelle. Thanks.
maman pushed a commit to transkripid/flowbite-react that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summarize the changes made and the motivation behind them.
Sizing (sm|md|lg) for ToggleSwitch component
I added some storybook example for now.
The examples will be on its own /docs/forms/toggleswitch page being worked on in #998.
Reference related issues using
#followed by the issue number.#998
If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.
added sizing prop. Not a breaking change. default is still md (which has class w-11 h-6 ...)