Skip to content
This repository was archived by the owner on May 29, 2023. It is now read-only.

Conversation

@jordisantamaria
Copy link
Contributor

The plugin is giving soo many errors all time, so I think It would be nice to let user decide what files want to autosave, to avoid those errors. Also mksession is giving error sometimes, for example in q: mode, so include silent to avoid show those errors, they are so annoying.

Copy link
Owner

@thaerkh thaerkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I think the whitelist is fine and we can merge that, though separately from the Git repo constraint which we can put in a separate PR as a feature flag.

Forcing Git as a dependency isn't ideal in all scenarios, but if we add an option to auto-setup sessions for root-dir git repos then I think that would be a great feature.

@jordisantamaria
Copy link
Contributor Author

I see, thanks for feedback, my bad to request PR with master branch, I included git feature later lol. I will update It to give a flag for git repository then.

@jordisantamaria
Copy link
Contributor Author

@thaerkh I updated It to include variable g:workspace_only_git_dir to activate workspace only for git repositorys. Is it ok like this?

@thaerkh
Copy link
Owner

thaerkh commented Nov 25, 2021

This looks good to me, thank you!

@thaerkh thaerkh merged commit c26b473 into thaerkh:master Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants