Skip to content

Conversation

hcg1023
Copy link
Contributor

@hcg1023 hcg1023 commented Feb 28, 2024

fix #311

@afontcu
Copy link
Member

afontcu commented Mar 7, 2024

hey! thank you for this :) it would be great if you could add a small test to assert that the bug is fixed – and to make sure it doesn't pop up again in the future.

thank you!

@hcg1023
Copy link
Contributor Author

hcg1023 commented Mar 7, 2024

@afontcu I added test case

Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Added a few comments, almost there!

@afontcu afontcu merged commit 3ecde9e into testing-library:main Mar 18, 2024
Copy link

🎉 This PR is included in version 8.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants