Skip to content

feat: use "object literal" instead of "switch" condition #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: use "object literal" instead of "switch" condition #285

wants to merge 1 commit into from

Conversation

AleTid5
Copy link

@AleTid5 AleTid5 commented Sep 27, 2022

Description

The file fire-event.js had a switch statement to handle the fireEvent.update function. In this PR the file was moved into a folder called "fire-event" and a new File called "input-type-actions.js" has been created. In this file, the previous switch logic has been moved and adapted in order to use an Object literal pattern.

Changes

  • Instead of using a Switch, an Object has been created
  • There are no breaking changes
  • Same tests are running and passing as in previous version
  • Code has been cleaned and optimised
@afontcu afontcu closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@AleTid5 @afontcu