Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = {
extends: [
'./node_modules/kcd-scripts/eslint.js',
'plugin:vue/recommended',
'prettier/vue',
'prettier',
],
plugins: ['vue'],
rules: {
Expand All @@ -18,5 +18,6 @@ module.exports = {
'testing-library/no-manual-cleanup': 'off',
'testing-library/no-await-sync-events': 'off',
'testing-library/await-fire-event': 'error',
'testing-library/prefer-user-event': 'off',
},
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"graphql-tag": "^2.11.0",
"isomorphic-unfetch": "^3.0.0",
"jest-serializer-vue": "^2.0.2",
"kcd-scripts": "^7.0.3",
"kcd-scripts": "^11.1.0",
"lodash.merge": "^4.6.2",
"msw": "^0.26.2",
"portal-vue": "^2.1.7",
Expand Down
1 change: 1 addition & 0 deletions src/__tests__/form-user-event.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-enable testing-library/prefer-user-event */
import '@testing-library/jest-dom'
import {render, waitFor} from '@testing-library/vue'
import userEvent from '@testing-library/user-event'
Expand Down
4 changes: 1 addition & 3 deletions src/__tests__/render.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ test('renders container', () => {
template: '<div data-testid="myDiv">my content</div>',
})

expect(container.firstChild).toHaveTextContent(
getByTestId('myDiv').textContent,
)
expect(container).toHaveTextContent(getByTestId('myDiv').textContent)
})

test('container defaults to div', () => {
Expand Down
1 change: 1 addition & 0 deletions src/__tests__/select-user-event.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-enable testing-library/prefer-user-event */
import '@testing-library/jest-dom'
import {render} from '@testing-library/vue'
import userEvent from '@testing-library/user-event'
Expand Down
1 change: 1 addition & 0 deletions src/fire-event.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Object.keys(dtlFireEvent).forEach(key => {
fireEvent[key] = async (...args) => {
warnOnChangeOrInputEventCalledDirectly(args[1], key)

// eslint-disable-next-line testing-library/await-fire-event
dtlFireEvent[key](...args)
await waitFor(() => {})
}
Expand Down