Update delay document and add test confirming the delay behavior #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ph-fritsche requested changes Jan 21, 2025
Member
ph-fritsche left a comment
ph-fritsche left a comment There was a problem hiding this comment.
Thanks for contributing to this library.
ph-fritsche approved these changes Jan 21, 2025
| 🎉 This PR is included in version 14.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#1174
What:
This fixes a documentation error and adds a test to verify delay's behavior.
#1174
Why:
Correct documentation and quality tests make the library easier to use and adopt. The delay option is an important tool for helping write stable tests against asynchronous code.
How:
Comment adjustment. Straight forward test case proving the delay works as described.
Checklist:
Thanks for taking the time to review the change. Any feedback is appreciated.