docs(vue): update faq for Vue Router abstract mode #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
blimmer commented Jun 30, 2021
| }) | ||
| ``` | ||
| | ||
| 2. **Reset the window location `afterEach`**. If you don't want to pass an |
There was a problem hiding this comment.
This isn't the best option for people - they should instead use abstract mode, so don't recommend it.
| | ||
| // Unlike the router in `hash` mode, the initial routing stack is empty. So, | ||
| // you need to push an initial route to the stack. | ||
| await router.push('/') |
There was a problem hiding this comment.
cc @maxarndt - this adds the initial push you mentioned in testing-library/vue-testing-library#210 (comment)
| 2. **Reset the window location `afterEach`**. If you don't want to pass an | ||
| instantiated Router, you can instead reset the `window.location` after each | ||
| test, like this: | ||
| To reduce boilerplate, you can create a custom render function to use throughout |
There was a problem hiding this comment.
@maxarndt - if you've got some time for a contribution, it would be great to pull over the Custom Render setup guide from the react-testing-library docs (https://testing-library.com/docs/react-testing-library/setup#custom-render) to the currently blank setup page of Vue Testing Library (https://testing-library.com/docs/vue-testing-library/setup). Then, we could link to the custom render docs from this FAQ.
afontcu approved these changes Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This update is in response to a conversation between @maxarndt and I here. The workaround of resetting
window.locationhas some pitfalls, so this PR updates the documentation to only recommend usingabstractmode.