Skip to content

Conversation

@travis5491811
Copy link

@travis5491811 travis5491811 commented Apr 2, 2021

Add example using props in reference to .1 in testing-library/vue-testing-library#216 (comment)

@MatanBobi
Copy link
Member

@afontcu Can you please have a look at this one? :)

@afontcu
Copy link
Member

afontcu commented Apr 5, 2021

Hi! Thank you for taking the time 🙌

Given the fact that the guiding principle of Testing Lib is to test components in a real environement, I'm not entirely sure we should showcase a test using stubs as a "first" example. I would keep the test simpler, and focus only on props (which was the missing bit we identified on testing-library/vue-testing-library#216 :)

We could either simplify the example, or maybe add some props to the Button example.

Again, thanks for this!

Simplify example to focus on props
@travis5491811
Copy link
Author

Welcome @afontcu, I've reduced the example down to only focus on props. I also didn't realize my editor didn't pick up my spelling mistakes on the last commit. They showed immediately when I opened the patch. It's resolved now. Is this change okay?

@MatanBobi
Copy link
Member

@afontcu is this ready to be merged or can we close it? :)

@eps1lon eps1lon changed the title Add example using props Vue: Add example using props Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants