Skip to content

docs: Explicitly mention what is thrown #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2020
Merged

docs: Explicitly mention what is thrown #720

merged 1 commit into from
Dec 18, 2020

Conversation

@aleks-rope
Copy link
Contributor

@aleks-rope aleks-rope commented Dec 18, 2020

Just updating a sentence to make more sense.

From:

  • This throws if more than one match is found (use queryAllBy instead).

To:

  • This throws an error if more than one match is found (use queryAllBy instead).
eps1lon
eps1lon approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@eps1lon eps1lon changed the title Update grammar in sentence docs: Explicitly mention what is thrown Dec 18, 2020
@eps1lon eps1lon merged commit 3654f5c into testing-library:master Dec 18, 2020
@eps1lon
Copy link
Member

eps1lon commented Dec 18, 2020

@all-contributors add @aleks-rope for docs
@allcontributors allcontributors bot mentioned this pull request Dec 18, 2020
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Dec 18, 2020

@eps1lon

I've put up a pull request to add @aleks-rope! 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@aleks-rope @eps1lon