- Notifications
You must be signed in to change notification settings - Fork 732
add native-testing-library and update react faqs #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add native-testing-library and update react faqs #66
Conversation
| Thanks for the PR. A few questions -
|
| We could change "Wrappers" to "Frameworks". The sidebar heading isn't navigable so changing it doesn't break any links. |
| Yeah no problem!
In summary, I just had to refactor so much to get things to work in native, and had to re-word/edit so much of the docs to get to the end goal of giving native users the same confidence, that I believe it would be wrong to co-locate them. My original intent was to try to PR to dom-testing-library to support native, but it would’ve been gross. Everything, with the exception of maybe 2 or 3 files, had to change to accomplish this goal. I’ll modify the PR to put the sections wherever you want, but I think it’s unfair to DOM and native users to share a docs site, because although I want more than anything for them to “feel” the same, under the hood they are different libraries with different needs, and I think users of both should expect to maintain the same level of clarity when using the respective libraries. I hope this made sense 😬 |
| Personally, I think that even though this doesn't use dom-testing-library under the hood, it still makes sense to get the same first class treatment as the other implantations on the docs site. Lots of people ask me about a native solution despite the existing link. Having it as an actual part of the docs like everything else will give it more legitimacy I think. |
| Makes sense to me! You guys can just let me know what changes you want me to make to this PR to get it merged. The only thing that really matters to me is that it have its own site because of the fundamental differences between this and every other implementation in the family (I really think it'll cause less friction for the users). That said, whatever info about it you want in testing-library.com I'd be happy to provide! |
| At the risk of sounding like I'm proposing a corporate merger (avoiding the word "synergy" 😄), I think there's a lot of value in trying to stick to one site:
I think we can come up with a way to maintain a solid experience within the site that encapsulates all the React Native-specific stuff you've done. As Kent said on Twitter this is the strongest effort yet to get something that adheres to user-centric patterns on React Native and pairing it with the existing documentation should give it a string boost in terms of visibility and adoption. |
| This is still on my mind, I'm just still thinking about it. I don't want to rush to any conclusion. I think we both have a pretty deep conviction, and I want to make sure we've thought it through pretty thoroughly. I've been going back through the docs of both, there's just so much specific to Could they merge the docs for
These are just two examples, but really everything in the library would've been just as worthy of an example (except like, maybe Summary: although |
| Honestly I don't feel super strongly about it personally. It sounds like you do though and you have good reasons. I'm fine with just linking to the site instead 👍 |
| I'm OK with merging this as-is and thinking about how to better organize this later. I'll open a follow-up issue. |
Per a request from Kent on Twitter, I'm adding some information about the native-testing-library I built to the docs site. The page is bare, but only because the docs site is so comprehensive, so I just linked the readers to it.
The reason I added it to the ecosystem instead of wrappers is because it isn't really a
dom-testing-librarywrapper, but it does effectively implement the API... so I consider it part of the ecosystem. I know that doesn't really match with what the "ecosystem" section is right now, but it seemed like a better match than wrappers.If there's somewhere else you'd like me to put it, just let me know... I was just guessing that was the best place to put it. Thanks!