- Notifications
You must be signed in to change notification settings - Fork 733
Added company user for Testing library #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added Company which uses it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@afontcu Hello i saw you have been reviewing PRs , could you please take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please make the background of the image transparent so it's consistent with the other icons?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@nickmccurdy Sure. I made changes. |
Please resolve the merge conflicts. |
@AshifMohammad Can you please resolve the conflicts so we'll be able to merge this one? :) |
# Conflicts: # static/img/users/cdkglobal.png # website/siteConfig.js
@nickmccurdy @MatanBobi , Sorry for the delayed response :) . I resolved the merge conflicts. |
Hi @AshifMohammad, thanks for the feedback :) Please add it there and revert the |
@MatanBobi Thank you for the input, i refactored it and added the correct location in |
Thanks. Though I can still see the |
@MatanBobi Apologies, i should have removed it as we moved to docusaurus :) . I updated the PR. Thanks |
@MatanBobi @nickmccurdy could you please review the PR? |
@nickmccurdy Hi , Could i get some of your time to review this PR please? i am happy to make some more changes if required :) , Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickmccurdy , Nick this is the official logo i could get for this use. I am afraid if i could have the fully transparent logo. |
I'm closing this one as there was no progress for a year now. To merge this, we'll need an SVG version. Please feel free to create another PR :) |
Added Company which uses it