Skip to content

Conversation

AshifMohammad
Copy link

Added Company which uses it

Copy link
Author

@AshifMohammad AshifMohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AshifMohammad
Copy link
Author

@afontcu Hello i saw you have been reviewing PRs , could you please take a look at this?
Simple change to add the company which uses it, that's my company CDK Global Inc. and we have moved entirely on React Testing Library. 🐐

Copy link
Member

@nickserv nickserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make the background of the image transparent so it's consistent with the other icons?

@nickserv

This comment has been minimized.

@alexkrolick

This comment has been minimized.

@AshifMohammad
Copy link
Author

@nickmccurdy Sure. I made changes.
Thanks for the suggestions

@nickserv
Copy link
Member

Please resolve the merge conflicts.

@MatanBobi
Copy link
Member

@AshifMohammad Can you please resolve the conflicts so we'll be able to merge this one? :)

# Conflicts: #	static/img/users/cdkglobal.png #	website/siteConfig.js
@AshifMohammad
Copy link
Author

@nickmccurdy @MatanBobi , Sorry for the delayed response :) . I resolved the merge conflicts.
Thanks for reviewing the PR. Loved RTL btw 🙏🏼

@AshifMohammad AshifMohammad requested a review from nickserv March 17, 2021 12:33
@MatanBobi
Copy link
Member

Hi @AshifMohammad, thanks for the feedback :)
Regarding this PR, the companies using this have moved to a different place and they now reside here:
https://github.com/testing-library/testing-library-docs/blob/master/docusaurus.config.js#L19

Please add it there and revert the siteConfig file since it's an old file and was removed in our refactor :)

@AshifMohammad
Copy link
Author

@MatanBobi Thank you for the input, i refactored it and added the correct location in .docusaurus.config.js.

@MatanBobi
Copy link
Member

@MatanBobi Thank you for the input, i refactored it and added the correct location in .docusaurus.config.js.

Thanks. Though I can still see thesiteConfig file, you need to remove it.

@AshifMohammad
Copy link
Author

@MatanBobi Apologies, i should have removed it as we moved to docusaurus :) . I updated the PR. Thanks

@AshifMohammad
Copy link
Author

@MatanBobi @nickmccurdy could you please review the PR?

@AshifMohammad
Copy link
Author

@nickmccurdy Hi , Could i get some of your time to review this PR please? i am happy to make some more changes if required :) , Thanks

Copy link
Member

@nickserv nickserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The only remaining issue I'm seeing is that the logo has white spots on a dark background. Do you have a fully transparent or SVG version we could use?
image

@AshifMohammad
Copy link
Author

Thanks. The only remaining issue I'm seeing is that the logo has white spots on a dark background. Do you have a fully transparent or SVG version we could use?
image

@nickmccurdy , Nick this is the official logo i could get for this use. I am afraid if i could have the fully transparent logo.
meanwhile i will try to get the logo and raise another PR for that?

@AshifMohammad AshifMohammad requested a review from nickserv April 29, 2021 09:13
@MatanBobi
Copy link
Member

I'm closing this one as there was no progress for a year now. To merge this, we'll need an SVG version. Please feel free to create another PR :)

@MatanBobi MatanBobi closed this Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants